NCAS Radar 1.0.0 #48
Merged
NCAS Radar 1.0.0 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables in CfRadial and NCAS-RADAR require variables to either be scaler (i.e. have no dimensions) or have a defined dimension, which may result in the need to check the dimensions of a scaler variable. Previously, with scaler variables having dimensions listed as "" in the output from CDLReader.to_dict() function, trying to check dimensions would say it is undefined. This change allows checking whether a variable is a scaler (defined_attrs dimension:--none--) and allows checking if a variable is a scaler or has a defined dimension (rules_attrs dimension: rule-func:match-one-of:--none--|time).
Merge changes from main into ncas-radar branch
|
One of the dependencies needs numpy and was allowing the release candidate of version 2 to be downloaded and installed. This then caused problems with the netCDF4 module (I think this is addressed in the next release of the netCDF module, but not the current release v1.6.5). Solution is to only allow version 1 of numpy to be installed. |
|
The errors on those tests are due to the CEDA API for platform checks, rather than the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specs and checks needed for checking files against the NCAS-Radar standard.
A few of the bigger associated changes:
,, this has been changed to||. Some variables needed a rule check on their dimensions, as there were two valid options for dimensions (e.g. therangevariable could have dimensionsrangeorsweep, range), and multiple dimensions in an option are separated by,in the CDL representation of the file.--none--- some variable must or could be scaler, and so a check was needed for that, but checking scaler dimensions before identified them asUNDEFINED, as there was no value.--none--was chosen as to represent dimensions for scaler variables as dimensions in a netCDF file can not start with a hyphen, so this is a safe value to use.string_length. A regex check was needed to make sure there is at least one such dimension.